Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed documentation for sles #230

Merged
merged 5 commits into from
Aug 9, 2024
Merged

removed documentation for sles #230

merged 5 commits into from
Aug 9, 2024

Conversation

Apurv428
Copy link
Collaborator

@Apurv428 Apurv428 commented Aug 4, 2024

Signed-off-by: Apurv Sonawane <[email protected]>
@Apurv428 Apurv428 requested a review from pleia2 August 4, 2024 18:25
Signed-off-by: Apurv Sonawane <[email protected]>
Signed-off-by: Apurv Sonawane <[email protected]>
Signed-off-by: Apurv Sonawane <[email protected]>
Copy link
Contributor

@pleia2 pleia2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but we should also remove all inline references to Ubuntu since it's implied now. There were a couple other references that I couldn't reply to, on lines 154 and 178 in the original file, so you'll want to get those too, probably just want to search the file and make sure the only reference to Ubuntu is at the top 😄

I also think we should remove Ubuntu 18.04 and add 24.04 to the list now that it's been tested.

docs/docs/Installation.md Outdated Show resolved Hide resolved
docs/docs/Installation.md Outdated Show resolved Hide resolved
docs/docs/Installation.md Outdated Show resolved Hide resolved
docs/docs/Installation.md Outdated Show resolved Hide resolved
docs/docs/Installation.md Outdated Show resolved Hide resolved
docs/docs/Installation.md Outdated Show resolved Hide resolved
@Apurv428 Apurv428 requested a review from pleia2 August 5, 2024 19:43
@pleia2 pleia2 merged commit 9226476 into documentation Aug 9, 2024
1 check passed
@pleia2 pleia2 deleted the remove-sles branch August 9, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants